Skip to content

Allow passing a tuple to buff in SurroundingRectangle to specify buffer in x and y direction independently #4390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025

Conversation

nubDotDev
Copy link
Contributor

Overview: What does this pull request change?

Now you can give SurroundingRectangle a tuple[float, float] for its buff parameter to have different buffers in the x and y directions.

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! I like the extension of the buffer and have added one test to ensure it is behaving correctly.

@github-project-automation github-project-automation bot moved this from 🆕 New to 👍 To be merged in Dev Board Aug 11, 2025
@behackl behackl added the enhancement Additions and improvements in general label Aug 11, 2025
@behackl behackl added this to the v0.19.1 milestone Aug 11, 2025
@behackl behackl changed the title Give SurroundingRectangle 2D buffer Allow passing a tuple to buff in SurroundingRectangle to specify buffer in x and y direction independently Aug 11, 2025
@behackl behackl merged commit c4dc0ea into ManimCommunity:main Aug 11, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additions and improvements in general
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants